fix: Replace Console.WriteLine with ILogger in SyncService BoardHub#280
Closed
nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
Closed
fix: Replace Console.WriteLine with ILogger in SyncService BoardHub#280nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
Conversation
- Add ILogger<BoardHub> dependency injection - Convert 58 Console.WriteLine calls to structured logging: - State transitions → LogInformation - Missing data/not found → LogWarning - Exceptions → LogError - Update BoardHubTests to provide mock logger This improves production observability and enables proper log aggregation and filtering. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
nbhansen
force-pushed
the
fix/syncservice-logging
branch
from
b600cc8 to
b1a3ef0
Compare
github-project-automation
bot
moved this from Backlog
to Done
in Visual Tangible Artefacts - 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Console.WriteLinecalls inBoardHub.cswith properILoggercallsLogInformation: State transitions (register, connect, disconnect)LogWarning: Missing data, not found conditionsLogError: ExceptionsLogDebug: Verbose checks (already connected, etc.)Test plan