Phase 4.1-4.3: Structured logging & empty catch fixes#285
Merged
nbhansen merged 2 commits intoaau-giraf:dev-mainfrom Feb 8, 2026
Merged
Phase 4.1-4.3: Structured logging & empty catch fixes#285nbhansen merged 2 commits intoaau-giraf:dev-mainfrom
nbhansen merged 2 commits intoaau-giraf:dev-mainfrom
Conversation
- sync.sh: one-command reset of dev-main to upstream after squash-merges - .github/copilot-instructions.md: document git config, sync workflow, and standard PR merge procedure to prevent divergent branch issues
…ix empty catches Backend (4.1): - Replace 80 Console.WriteLines with ILogger<T> across 8 files - SyncController, MigrationService, BoardHub, ElevenLabsService, CategoriesController, WebApplicationExtensions use structured logging - DbContextExtensions, ImageUtilities use Console.Error (no DI available) - BoardHubTests updated with NullLogger Flutter (4.2): - Add package:logging ^1.3.0 with AppLogger.init() utility - Replace 509 print/debugPrint calls with Logger across 50 files - Remove 9 unused foundation.dart imports - Remove 12 avoid_print ignore directives Empty catches (4.3): - Add _log.fine/warning to 23 empty catch blocks across 8 Flutter files - 0 empty_catches lint warnings remain
github-project-automation
bot
moved this from Backlog
to Done
in Visual Tangible Artefacts - 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all ad-hoc Console.Write/print/debugPrint with structured logging frameworks, and fix all empty catch blocks.
Backend (4.1) — ILogger<T>
ILogger<T>across 8 source filesSyncController,MigrationService,BoardHub,ElevenLabsService,CategoriesController,WebApplicationExtensionsuse structured logging with{Placeholder}templatesDbContextExtensionsandImageUtilitiesuseConsole.Error.WriteLine(static contexts where DI is unavailable)BoardHubTestsupdated withNullLogger<BoardHub>.InstanceFlutter (4.2) — package:logging
logging: ^1.3.0dependencyAppLogger.init()utility (hierarchical logging, debug=ALL / release=WARNING, forwards todeveloper.log)Loggeracross 50 filesfoundation.dartimports and 12avoid_printignore directivesEmpty catches (4.3)
_log.fine/_log.warningto 23 empty catch blocks across 8 Flutter filesempty_catcheslint warnings remainVerification
dotnet build: 0 errors, 0 warningsflutter analyze: 0 errors (81 pre-existing warnings/infos only)