feat: add validation that payload has no storage vars#653
Open
brotherlymite wants to merge 5 commits intoaave-dao:mainfrom
Open
feat: add validation that payload has no storage vars#653brotherlymite wants to merge 5 commits intoaave-dao:mainfrom
brotherlymite wants to merge 5 commits intoaave-dao:mainfrom
Conversation
Contributor
♻️ Forge Gas SnapshotsSeems like you are not measuring gas of any operations yet. 🤔 |
Contributor
Forge Build Sizes
🔕 Unchanged
|
brotherlymite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds validation inside
defaultTestthat the payload address has no storage variables declared as it could mess with the executor storage as executor does delegateCall to the payload.This tests relies on the payload address artifact, so the payload address passed should be compiled inside the repo. Also for it you need to add
extra_output = ["storageLayout"]inside the foundry.tomlFor use in ad-hoc proposal where you don't have the compiled artifacts in the repo, you can simply override the method
_validateNoPayloadStorageSlotsand check manually.Checklist
pnpm changeset)