fix: Remove Spoke reserve getters #1110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-man
reviewed
Jan 13, 2026
Contributor
There was a problem hiding this comment.
should we also write the data provider contract and include here as part of this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft implementation gives a sense of the savings on bytecode size we could get by removing auxiliary reserve getters from the Spoke. They are only calling the
Hubcontract, so this is actually more efficient. In case this creates any ux friction, we can consider creating an adapter contract to expose all Spoke information in only one place.Bytecode size from 24,523 to 23,870