build: ensure we exit with correct error code when not failing fast

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

Author: Planeshifter

tools/make/lib/lint/javascript/eslint.mk

@@ -91,11 +91,16 @@ ifeq ($(FAIL_FAST), true)
 		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || exit 1; \
 	done
 else
-	$(QUIET) $(FIND_SOURCES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
+	$(QUIET) status=0; \
+	for file in $$($(FIND_SOURCES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
 		echo ''; \
 		echo "Linting file: $$file"; \
-		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || echo 'Linting failed.'; \
-	done
+		if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file; then \
+			echo 'Linting failed.'; \
+			status=1; \
+		fi; \
+	done; \
+	exit $$status;
 endif
 
 .PHONY: eslint-src
@@ -127,11 +132,16 @@ ifeq ($(FAIL_FAST), true)
 		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_TESTS) $$file || exit 1; \
 	done
 else
-	$(QUIET) $(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
+	$(QUIET) status=0; \
+	for file in $$($(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
 		echo ''; \
 		echo "Linting file: $$file"; \
-		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_TESTS) $$file || echo 'Linting failed.'; \
-	done
+		if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_TESTS) $$file; then \
+			echo 'Linting failed.'; \
+			status=1; \
+		fi; \
+	done; \
+	exit $$status;
 endif
 
 .PHONY: eslint-tests
@@ -163,11 +173,16 @@ ifeq ($(FAIL_FAST), true)
 		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_EXAMPLES) $$file || exit 1; \
 	done
 else
-	$(QUIET) $(FIND_EXAMPLES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
+	$(QUIET) status=0; \
+	for file in $$($(FIND_EXAMPLES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
 		echo ''; \
 		echo "Linting file: $$file"; \
-		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_EXAMPLES) $$file || echo 'Linting failed.'; \
-	done
+		if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_EXAMPLES) $$file; then \
+			echo 'Linting failed.'; \
+			status=1; \
+		fi; \
+	done; \
+	exit $$status;
 endif
 
 .PHONY: eslint-examples
@@ -199,11 +214,16 @@ ifeq ($(FAIL_FAST), true)
 		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_BENCHMARKS) $$file || exit 1; \
 	done
 else
-	$(QUIET) $(FIND_BENCHMARKS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
+	$(QUIET) status=0; \
+	for file in $$($(FIND_BENCHMARKS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
 		echo ''; \
 		echo "Linting file: $$file"; \
-		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_BENCHMARKS) $$file || echo 'Linting failed.'; \
-	done
+		if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_BENCHMARKS) $$file; then \
+			echo 'Linting failed.'; \
+			status=1; \
+		fi; \
+	done; \
+	exit $$status;
 endif
 
 .PHONY: eslint-benchmarks
@@ -232,11 +252,16 @@ ifeq ($(FAIL_FAST), true)
 		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || exit 1; \
 	done
 else
-	$(QUIET) for file in $(FILES); do \
+	$(QUIET) status=0; \
+	for file in $(FILES); do \
 		echo ''; \
 		echo "Linting file: $$file"; \
-		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || echo 'Linting failed.'; \
-	done
+		if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file; then \
+			echo 'Linting failed.'; \
+			status=1; \
+		fi; \
+	done; \
+	exit $$status;
 endif
 
 .PHONY: eslint-files