Fixes matches for Fedora / Kali-like ifconfig outputs#29
Open
dkran wants to merge 5 commits intoabandonware:masterfrom
dkran:master
Open
Fixes matches for Fedora / Kali-like ifconfig outputs#29dkran wants to merge 5 commits intoabandonware:masterfrom dkran:master
dkran wants to merge 5 commits intoabandonware:masterfrom
dkran:master
Conversation
Author
|
Not sure why this disrupted here. Any insights? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few matches don't seem to work nicely on Kali linux, and also looking around the web fedora does the same output style with ifconfig. This solves it as cleanly as I can for the two "ifconfig flavors" I've seem to come across.. on a side note, the kali / fedora way of doing it also has a ':' after the interface name. Taking in this pull request would greatly simplify my program lol. I will work on other aspects of your code as I continue writing my app and find any other inconsistencies... (iwconfig, for example?)