Skip to content

Fixed the compatibility with the newer ABAP on-prem systems #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed the compatibility with the newer ABAP on-prem systems #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6647cb3
Fixed the dump caused by the missing "get_instance" method.
CiozZ Dec 16, 2023
f0c979b
Removed the old commented code.
CiozZ Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zcl_abapgit_res_repo_stage.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
ENDIF.
ENDLOOP.
*------ Author and Committer details
lo_user = zcl_abapgit_persistence_user=>get_instance( ).

Check failure on line 169 in src/zcl_abapgit_res_repo_stage.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_instance" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

DATA(lv_user) = lo_user->get_repo_git_user_name( lo_repo_online->get_url( ) ).
IF lv_user IS INITIAL.
Expand All @@ -174,7 +174,7 @@
ENDIF.
IF lv_user IS INITIAL.
" get default from user master record
lv_user = zcl_abapgit_user_record=>get_instance( sy-uname )->get_name( ).

Check failure on line 177 in src/zcl_abapgit_res_repo_stage.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_instance" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
ENDIF.

DATA(lv_email) = lo_user->get_repo_git_user_email( lo_repo_online->get_url( ) ).
Expand All @@ -183,7 +183,7 @@
ENDIF.
IF lv_email IS INITIAL.
" get default from user master record
lv_email = zcl_abapgit_user_record=>get_instance( sy-uname )->get_email( ).

Check failure on line 186 in src/zcl_abapgit_res_repo_stage.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_instance" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
ENDIF.

ls_response_data-abapgit_comment-author-name = lv_user.
Expand Down Expand Up @@ -288,4 +288,4 @@
lr_wb_object->get_global_wb_key( IMPORTING p_object_type = rs_wbtype ).
ENDIF.
ENDMETHOD.
ENDCLASS.
ENDCLASS.
2 changes: 1 addition & 1 deletion src/zcl_abapgit_res_repos.clas.locals_imp.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
MESSAGE e004(za4c_agit_adt) WITH iv_transport_request INTO lv_error_message.
zcx_abapgit_exception=>raise_t100( ).
ELSEIF ls_e070-as4user NE sy-uname.
MESSAGE e005(za4c_agit_adt) WITH iv_transport_request INTO lv_error_message.

Check failure on line 29 in src/zcl_abapgit_res_repos.clas.locals_imp.abap

View check run for this annotation

abaplint / abaplint

Message 005, expected 2 WITH parameters 

https://rules.abaplint.org/message_exists
zcx_abapgit_exception=>raise_t100( ).
ENDIF.

Expand All @@ -45,7 +45,7 @@

"Set the default transport request
IF is_request_data-transportrequest IS NOT INITIAL.
zcl_abapgit_default_transport=>get_instance( )->set( CONV #( is_request_data-transportrequest ) ).
NEW zcl_abapgit_default_transport( )->zif_abapgit_default_transport~set( CONV #( is_request_data-transportrequest ) ).

Check failure on line 48 in src/zcl_abapgit_res_repos.clas.locals_imp.abap

View check run for this annotation

abaplint / abaplint

Reduce line length to max 120, currently 124 

https://rules.abaplint.org/line_length
ENDIF.

"Create online repo
Expand Down
1 change: 0 additions & 1 deletion src/zcx_adt_rest_abapgit.clas.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
</VSEOCLASS>
<DESCRIPTIONS>
<SEOCOMPOTX>
<CLSNAME>ZCX_ADT_REST_ABAPGIT</CLSNAME>
<CMPNAME>CONSTRUCTOR</CMPNAME>
<LANGU>E</LANGU>
<DESCRIPT>CONSTRUCTOR</DESCRIPT>
Expand Down
Loading