Skip to content

Codecleanupandcacheing#38

Open
curenect-meiner wants to merge 48 commits intoabdellahrk:mainfrom
curenect-meiner:codecleanupandcacheing
Open

Codecleanupandcacheing#38
curenect-meiner wants to merge 48 commits intoabdellahrk:mainfrom
curenect-meiner:codecleanupandcacheing

Conversation

@curenect-meiner
Copy link
Contributor

@curenect-meiner curenect-meiner commented Dec 19, 2025

#37

Dustin Meiner added 30 commits December 16, 2025 01:25
…onfiguration handling and add type assertions
…e, Book, and OpenGraph classes for improved clarity and type safety
…rface for improved clarity and type safety
…ous classes for improved clarity and type safety
…rface for improved clarity and type safety
Dustin Meiner added 15 commits December 19, 2025 22:26
…xtension and enhance type safety with readonly properties
…sses for enhanced immutability and type safety
# Conflicts:
#	src/Twig/Extensions/MetaTagsExtension.php
#	src/Twig/Extensions/OpenGraphExtension.php
…terface for improved clarity and type safety
@curenect-meiner
Copy link
Contributor Author

curenect-meiner commented Dec 19, 2025

heyo. Ich used rector, php-cs-fixer and phpstan lvl 10 to make it all clean and save.

I switched to symfony 6.4 min requirement because of the security issues.
And because of deprications.
In this step i also removed the Annotations check.
Because nobody should use them.

i also implement caching in the seo everntlistener with default for 1 week ttl.
Also an option to set them in the config to overwrite it.

i also test the sitemap generation and find this part
$instance instanceof Attributes\Sitemap
its never true because the instance is always a Route
edit: ah now i understand how it works :D

Say anything you are not cool with and i will change it.

@curenect-meiner curenect-meiner marked this pull request as ready for review December 19, 2025 23:15
@abdellahrk
Copy link
Owner

@curenect-meiner thank you very much for the contribution and hard work.
To enable us test correctly, could you please break the PR in multiple chunks or per feature within the bundle?
So that we make sure nothing breaks along the way.
Sorry for the late reply on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants