feat: complete API and unit tests for all types but Solver#40
Merged
abdoo8080 merged 13 commits intoabdoo8080:mainfrom Apr 7, 2026
Merged
feat: complete API and unit tests for all types but Solver#40abdoo8080 merged 13 commits intoabdoo8080:mainfrom
Solver#40abdoo8080 merged 13 commits intoabdoo8080:mainfrom
Conversation
abdoo8080
reviewed
Apr 7, 2026
Owner
abdoo8080
left a comment
abdoo8080
left a comment
There was a problem hiding this comment.
LGTM! I left some comments., but they can be addressed in a separate PR!
Comment on lines
+216
to
+217
| -- -- no dedicated parser error | ||
| -- test![TestApiBlackInputParser, parserErrors] |
Owner
There was a problem hiding this comment.
I think we can add them as new constructors to our cvc5.Error type?
Comment on lines
+25
to
+26
| -- -- skipped as the lean API does not allow retrieving the solver | ||
| -- test![TestApiBlackInputParser, getSolver] |
Owner
There was a problem hiding this comment.
Any reason for not supporting this? If the reason is me, then we can go ahead and support it!
Comment on lines
+28
to
+29
| -- -- skipped as the lean API does not allow retrieving the symbol manager | ||
| -- test![TestApiBlackInputParser, getSymbolManager] |
Comment on lines
+124
to
+125
| -- -- tests `InputParser.setStreamInput`, which the lean API does not have | ||
| -- test![TestApiBlackInputParser, nextCommand] |
Owner
There was a problem hiding this comment.
Maybe we can add support for InputParser.setStreamInput using handles?
Collaborator
Author
There was a problem hiding this comment.
(I assume you meant IO.FS.Stream and not IO.FS.Handle.)
I agree this should be investigated, but it seems a bit tricky to me, tricky enough to require some discussion. Unless we think this is an urgent feature I would postpone it for a later PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solver, only exception isTerm.toStringValueSolver's, exceptTerm.toStringValuetestsThis PR does add that many functions to the API, as all types but
Solverwere already close to being complete. The main contribution is the unit tests, in particular forTermManagerwhich has a lot more tests now.