Skip to content

Feature/remove utc timezone #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeckDev merged 5 commits into from
Nov 6, 2025
Merged

Feature/remove utc timezone #12

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
925a99c
Update time formatting to German Time in timetable service and tool d…
abeckDev Nov 6, 2025
2d93bbc
Refactor date handling in GetStationBoardAsync to prioritize user-pro…
abeckDev Nov 6, 2025
9e53b68
Initial plan
Copilot Nov 6, 2025
d6d4c53
Add comprehensive timezone logic tests for date handling
Copilot Nov 6, 2025
200ed86
Merge pull request #13 from abeckDev/copilot/sub-pr-12
abeckDev Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions AbeckDev.DbTimetable.Mcp/Services/TimeTableService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,32 @@ public async Task<string> GetStationBoardAsync(
CancellationToken cancellationToken = default)
{
// Format: yyMMddHHmm (e.g., 2511051830 for 2025-11-05 18:30)
var dateParam = date?.ToString("yyMMdd") ?? DateTime.UtcNow.ToString("yyMMdd");
var hourParam = date?.ToString("HH") ?? DateTime.UtcNow.ToString("HH");
// If date is provided by user, use it directly (user is expected to provide German time)
// If not provided, get current time in German timezone
DateTime effectiveTime;
if (date.HasValue)
{
effectiveTime = date.Value;
}
else
{
try
{
var tz = TimeZoneInfo.FindSystemTimeZoneById("Europe/Berlin");
effectiveTime = TimeZoneInfo.ConvertTimeFromUtc(DateTime.UtcNow, tz);
}
catch (TimeZoneNotFoundException)
{
effectiveTime = DateTime.Now; // fallback to local time if timezone not found
}
catch (InvalidTimeZoneException)
{
effectiveTime = DateTime.Now; // fallback to local time if timezone invalid
Comment thread
abeckDev marked this conversation as resolved.
Comment thread
abeckDev marked this conversation as resolved.
}
}

var dateParam = effectiveTime.ToString("yyMMdd");
var hourParam = effectiveTime.ToString("HH");

using var request = new HttpRequestMessage(HttpMethod.Get, $"plan/{evaNo}/{dateParam}/{hourParam}");
request.Headers.Add("DB-Client-Id", _config.ClientId);
Expand Down
4 changes: 2 additions & 2 deletions AbeckDev.DbTimetable.Mcp/Tools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public async Task<string> GetFullStationChanges(
[Description("Get station board (departures and arrivals) for a specific station in hourly slices. Returns XML data with train schedules.")]
public async Task<string> GetStationBoard(
[Description("EVA station number (e.g., 8000105 for Frankfurt Hauptbahnhof)")] string evaNo,
[Description("Date and time in format 'yyyy-MM-dd HH:mm' (UTC). Leave empty for current time.")] string? dateTime = null)
[Description("Date and time in format 'yyyy-MM-dd HH:mm' (German Time). Leave empty for current time.")] string? dateTime = null)
{
try
{
Expand Down Expand Up @@ -119,7 +119,7 @@ public async Task<string> GetStationBoard(
public async Task<string> FindTrainConnections(
[Description("Starting station name or EVA number (e.g., 'Frankfurt Hbf' or '8000105')")] string stationA,
[Description("Destination station name or EVA number (e.g., 'Berlin Hbf' or '8011160')")] string stationB,
[Description("Date and time in format 'yyyy-MM-dd HH:mm' (UTC). Leave empty for current time.")] string? dateTime = null)
[Description("Date and time in format 'yyyy-MM-dd HH:mm' (German Time). Leave empty for current time.")] string? dateTime = null)
{
try
{
Expand Down