fix: remove unsupported Web Crypto MD5 implementation#151
fix: remove unsupported Web Crypto MD5 implementation#151YougLin-dev wants to merge 6 commits intoabhay-ramesh:mainfrom
Conversation
Web Crypto API does not support MD5 algorithm (only SHA-1/256/384/512). The previous code would fail in browser environments. Since batch delete operations require S3 credentials, they should only run on the server anyway. Now always using Node.js crypto.createHash.
|
@YougLin-dev is attempting to deploy a commit to the Abhay's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis change simplifies MD5 generation in the storage client by removing browser/Web Crypto and dynamic-import branches; Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Test plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.