Prevent reconnect when desk is already connected#37
Open
Dinges28 wants to merge 1 commit intoabmantis:mainfrom
Open
Prevent reconnect when desk is already connected#37Dinges28 wants to merge 1 commit intoabmantis:mainfrom
Dinges28 wants to merge 1 commit intoabmantis:mainfrom
Conversation
This fixes the root cause of the “Notifications are already enabled” BleakError. The ConnectionManager could call `_connect()` while the desk was already connected, causing BLE notifications to be registered multiple times. This resulted in Bleak raising an error and Home Assistant logging repeated task exceptions. This change adds an early guard using `idasen_desk.is_connected` to prevent reconnect attempts when the connection is already active. This avoids duplicate connect/pair/notify calls and fixes the BLE race condition instead of suppressing errors. Tested with IKEA Idasen desks via ESP32 Bluetooth Proxy and native BLE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the root cause of the “Notifications are already enabled” BleakError.
The ConnectionManager could call
_connect()while the desk was already connected, causing BLE notifications to be registered multiple times. This resulted in Bleak raising an error and Home Assistant logging repeated task exceptions.This change adds an early guard using
idasen_desk.is_connectedto prevent reconnect attempts when the connection is already active.This avoids duplicate connect/pair/notify calls and fixes the BLE race condition instead of suppressing errors.
Tested with IKEA Idasen desks via ESP32 Bluetooth Proxy and native BLE.