Skip to content

Replace ASSERT statements with if statements #175 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace ASSERT statements with if statements #175 #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfc1a8c
Replaced ASSERT statements with if statements raising valueERROR(No. 2)
shafi456 Feb 3, 2025
3047c54
Correction for wrong code formatting
shafi456 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/container_inspector/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def container_inspector_squash(image_path, extract_directory):

def _container_inspector_squash(image_path, extract_directory):
images = get_images_from_dir_or_tarball(image_path)
assert len(images) == 1, 'Can only squash one image at a time'
if(len(images) == 1):
Copy link
Member

@pombredanne pombredanne Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code formatted? Is this if statement correct?
You need to have a hard look, and if need be, also add a test that passes before making this change.

raise ValueError("Can only squash one image at a time")
img = images[0]
target_loc = os.path.abspath(os.path.expanduser(extract_directory))
rootfs.rebuild_rootfs(img, target_loc)
Expand Down
Loading