-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add support to mine maven Package-URLs #660 #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jono Yang <[email protected]>
* Create basic work loop Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
minecode_pipeline/pipes/__init__.py
Outdated
| f.write(saneyaml.dump(data)) | ||
|
|
||
|
|
||
| def write_purls_to_repo(repo, package, packages, push_commit=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AyanSinhaMahapatra I've moved your write_packageurls_to_file and write_purls_to_repo functions to this file and I see that we have overlapping functionality here, especially with the code in https://github.com/aboutcode-org/purldb/blob/main/minecode_pipeline/pipes/pypi.py#L135
I think we should use a common function to do these actions
Signed-off-by: Jono Yang <[email protected]>
minecode_pipeline/pipes/__init__.py
Outdated
|
|
||
| def write_packageurls_to_file(repo, base_dir, packageurls): | ||
| purl_file_rel_path = os.path.join(base_dir, PURLS_FILENAME) | ||
| purl_file_rel_path = os.path.join(base_dir, hashid.PURLS_FILENAME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonoYang @AyanSinhaMahapatra I think we should avoid computing the package URL path and just use this function. ppath = hashid.get_package_purls_yml_file_path(package)
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* leading segment will be the repo itself, not a directory within the repo Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Create function to get checkpoint from checked out settings repo Signed-off-by: Jono Yang <[email protected]>
…uctor #660 Signed-off-by: Jono Yang <[email protected]>
1e044b5 to
289c336
Compare
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* This is done in the collect_packages_from_maven step Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
de1526c to
78045ef
Compare
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
e12a084 to
77295a3
Compare
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonoYang thanks++, LGTM!
A couple of minor comments for your consideration.
I've also enabled trusted publishing, and created the repos, we can start testing this in the CI.
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
References: