Skip to content

Conversation

@ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Sep 3, 2025

@ziadhany ziadhany force-pushed the min-cargo branch 2 times, most recently from 5cdc47b to ae60ff2 Compare September 4, 2025 23:13
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, looks good as a start. Please see my comments for your consideration

@pombredanne
Copy link
Member

@ziadhany what's left todo here?

@ziadhany
Copy link
Collaborator Author

@pombredanne I just need to use the common function. But I already tested running the workflow in this repo: https://github.com/ziadhany/cargo-test/. I will update it today.

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, looking good.
See my comments for your consideration. We can also start testing this in the aboutcode-data CI now


DATA_DIR = Path(__file__).parent.parent / "test_data" / "cargo"


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more tests for cargo mining would be nice, we can create a small repo with some commits to test, this is okay

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, looks good. Could you use these repositories instead:

And run this using the CI action added at aboutcode-data/minecode-pipelines-config#1?

The issue can be closed with this ^
Merging the PR as everything looks good otherwise.

Signed-off-by: ziad hany <[email protected]>
Refactor code to be compatible with the new pipeline.

Signed-off-by: ziad hany <[email protected]>
Add logging and fix bug in process_cargo_packages

Signed-off-by: ziad hany <[email protected]>
Fix bug in process_cargo_packages.

Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit e389935 into aboutcode-org:main Sep 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants