Skip to content

Resolve logger issue and update Swift pipeline to use commit hashes #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2025
Merged

Resolve logger issue and update Swift pipeline to use commit hashes #745

merged 3 commits into from
Oct 28, 2025

Conversation

@ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Oct 6, 2025 •
edited
Loading

  • Add a self.log logger to commit_and_push_changes function in Swift, CRAN, and Compose
  • Log only PURLs before committing to avoid excessive logging, which slows down the pipeline.
  • Use commit hash when no tag or version is available in Swift repository
  • Add tests for Swift

@ziadhany
Fix a logger bug add the print as default
c58cf82 
Use commit hash if no tag/version in swift repo
Add test for swift

Signed-off-by: ziad hany <[email protected]>
@ziadhany ziadhany changed the title Swift pipeline: use commit hashes and resolve logger issue resolve logger issue and update Swift pipeline to use commit hashes Oct 6, 2025
@ziadhany ziadhany changed the title resolve logger issue and update Swift pipeline to use commit hashes Resolve logger issue and update Swift pipeline to use commit hashes Oct 6, 2025
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziadhany LGTM! Have you run this online on the CI? If so please link the pipeline run there too for reference.

@ziadhany
Copy link
Collaborator Author

ziadhany commented Oct 23, 2025 •
edited
Loading

@AyanSinhaMahapatra I removed logging for every processed file because it slows things down a lot (we’re now focusing on logging only before committing), as seen in this PR:

@ziadhany
Copy link
Collaborator Author

@ziadhany LGTM! Have you run this online on the CI? If so please link the pipeline run there too for reference.

I’ll run it locally for now, and once I merge today, I’ll run it on CI.

AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @ziadhany
Please merge!

@ziadhany ziadhany merged commit 10081dd into main Oct 28, 2025
6 checks passed
@ziadhany ziadhany deleted the fix-empty-commit branch October 28, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ziadhany @AyanSinhaMahapatra