Skip to content

Properly assign boolean to is_resolved #3152 #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Properly assign boolean to is_resolved #3152 #3153

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c24c221
Properly assign boolean to is_resolved #3152
JonoYang Nov 19, 2022
4ce06b3
Update test expectations #3152
JonoYang Nov 21, 2022
81ed761
Merge branch 'develop' into 3152-maven-pom-dep-assign-is_resolved
AyanSinhaMahapatra Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/packagedcode/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ def get_dependencies(pom):
if dversion == 'latest.release':
dversion = None

is_resolved = dversion and not any(c in dversion for c in '$[,]')
is_resolved = bool(dversion and not any(c in dversion for c in '$[,]'))

dqualifiers = {}
# FIXME: this is missing from the original Pom parser
Expand Down
44 changes: 22 additions & 22 deletions ...kagedcode/data/license_detection/license-as-manifest-comment/activemq-camel.expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/commons-logging/commons-logging-api?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -20,7 +20,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.camel/camel-jms?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -34,7 +34,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.activemq/activemq-core?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -48,7 +48,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.activemq/activemq-pool?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -62,7 +62,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.geronimo.specs/geronimo-annotation_1.0_spec?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -76,7 +76,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.activemq/activemq-core?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -90,7 +90,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.camel/camel-core?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -104,7 +104,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.apache.camel/camel-spring?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -118,7 +118,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.springframework/spring-test?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -132,7 +132,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/junit/junit?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand All @@ -146,7 +146,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {},
"dependency_uid": "pkg:maven/org.hamcrest/hamcrest-all?uuid=fixed-uid-done-for-testing-5642512d1758",
Expand Down Expand Up @@ -401,7 +401,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -411,7 +411,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -421,7 +421,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -431,7 +431,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -441,7 +441,7 @@
"scope": "compile",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -451,7 +451,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -461,7 +461,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -471,7 +471,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -481,7 +481,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -491,7 +491,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
},
Expand All @@ -501,7 +501,7 @@
"scope": "test",
"is_runtime": false,
"is_optional": true,
"is_resolved": null,
"is_resolved": false,
"resolved_package": {},
"extra_data": {}
}
Expand Down
Loading