Skip to content

Conversation

@AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Sep 27, 2023

Adds a new option --purl to only parse and return in package data the purl fields, in package scan.

Reference: #3464

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be simpler not to introduce a purl_only=False arg everywhere and instead just to the purl-only thing on the output of the parse?

@AyanSinhaMahapatra AyanSinhaMahapatra added this to the v32.1 milestone Jan 8, 2024
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the purls-only branch 2 times, most recently from 5e0820d to 00c2113 Compare January 11, 2024 13:19
Adds a new option --purl to only parse and return in
package data the purl fields, in package scan.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

Closing this in favor of the updated implementation at: #3689
This is:

  • simpler code, easier to maintain and has fewer changes
  • also has other metadata with purl, but does not still perform license/copyright detection, so just as fast.

@AyanSinhaMahapatra AyanSinhaMahapatra deleted the purls-only branch January 14, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants