-
-
Notifications
You must be signed in to change notification settings - Fork 617
Support SPDX License List 3.23 #3653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reference: aboutcode-org/scancode-licensedb#49 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Referemce: aboutcode-org/scancode-licensedb#49 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
db4f3a8 to
0f4a319
Compare
Reference: aboutcode-org/scancode-licensedb#49 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
0f4a319 to
4108505
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
4108505 to
5a39c21
Compare
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
src/licensedcode/data/rules/fsfap-no-warranty-disclaimer_1.RULE
Outdated
Show resolved
Hide resolved
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few nits on copyrights... and good to merge otherwise!
Thanks
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please our texts as-is and add add new rules with the SPDX texts rather than modifying our texts.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
7b38ff8 to
125c1df
Compare
|
@pombredanne thanks for the comments, updated them to preserve the original texts. |
DennisClark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AyanSinhaMahapatra I tried really hard to find problems, but did not succeed! This looks ready to go, thanks.
|
Thanks @DennisClark @pombredanne , merging! |
Reference: aboutcode-org/scancode-licensedb#49
Tasks
Run tests locally to check for errors.