Add new license rules for new Elasticsearch notices #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucleonGodX
changed the title
NucleonGodX
force-pushed
the
elastic-rule
branch
2 times, most recently
from
82e2675 to
89f1608
Compare
AyanSinhaMahapatra
requested changes
Apr 7, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@NucleonGodX Thanks for the PR.
Please see my comments for your consideration.
src/licensedcode/data/rules/elastic-license-v2_or_agpl-3.0_or_mongodb-sspl-1.0_2.RULE
Outdated
Show resolved
Hide resolved
src/licensedcode/data/rules/elastic-license-v2_or_agpl-3.0_or_mongodb-sspl-1.0_3.RULE
Show resolved
Hide resolved
|
|
||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "{{Elastic License}} | ||
| * 2.0", the "{{GNU Affero General Public License v3.0 only}}", and the "{{Server Side |
Member
There was a problem hiding this comment.
Include the 2.0 in the required phrase: "{{Elastic License 2.0}}"
Also add the required phrase to all the instances of license names over this rules and other rules you've added to this PR.
Signed-off-by: NucleonGodX <[email protected]>
Signed-off-by: NucleonGodX <[email protected]>
…mongodb-sspl-1.0_2.RULE Co-authored-by: Ayan Sinha Mahapatra <[email protected]> Signed-off-by: NucleonGodX <[email protected]>
Signed-off-by: NucleonGodX <[email protected]>
NucleonGodX
force-pushed
the
elastic-rule
branch
from
64e7a10 to
72bae9c
Compare
Contributor
Author
|
Thanks for the review @AyanSinhaMahapatra |
pombredanne
approved these changes
Apr 21, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Looking fine. I will squash merge to get a cleaner history.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3942
Tasks
Run tests locally to check for errors.
Signed-off-by: NucleonGodX [email protected]