Skip to content

Conversation

@AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 8, 2025

Fixes #4045

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

These license were added to dejacode by @DennisClark

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #4045
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as draft January 8, 2025 15:38
@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as ready for review January 9, 2025 15:00
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@DennisClark DennisClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra Please see my comments on 4 licenses regarding the Owner names.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits wrt. rules.

@DennisClark
Copy link
Member

DennisClark commented Jan 9, 2025

@AyanSinhaMahapatra i have completed my review of the new/updated licenses and owners in DejaCode, applying the standard data enrichments, and no corrections were necessary.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne @DennisClark for your suggestions, I've incorporated them all. Ready for review again

Copy link
Member

@DennisClark DennisClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

These were added by @DennisClark

Reference: #4080
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit ce6251c into develop Jan 10, 2025
40 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-licenses branch January 10, 2025 09:47
AyanSinhaMahapatra added a commit that referenced this pull request Jan 14, 2025
Reference: #4081
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra added a commit that referenced this pull request Jan 14, 2025
Reference: #4081
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra added a commit that referenced this pull request Jan 15, 2025
Reference: #4081
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
alok1304 pushed a commit to alok1304/scancode-toolkit that referenced this pull request May 30, 2025
Reference: aboutcode-org#4081
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Alok Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Synchronize new and updated SPDX licenses for Release 3.26.0

4 participants