Skip to content

Conversation

@alok1304
Copy link
Collaborator

@alok1304 alok1304 commented Jan 19, 2025

Adding test for false positive GPL3 License.

Fixes #3932

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar [email protected]

@alok1304 alok1304 force-pushed the add-test-false-positive-gpl3 branch from 482a798 to 08f5769 Compare January 19, 2025 14:20
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alok1304, please see my review comments for your consideration

@alok1304 alok1304 force-pushed the add-test-false-positive-gpl3 branch 2 times, most recently from 37e942b to 5e53d12 Compare April 5, 2025 18:10
Reference: httpe://github.com/aboutcode-org/issues/3932
Signed-off-by: Alok Kumar <[email protected]>
@alok1304 alok1304 force-pushed the add-test-false-positive-gpl3 branch from 5e53d12 to 5dd3418 Compare April 11, 2025 18:17
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit ff88b06 into aboutcode-org:develop Apr 23, 2025
38 checks passed
@AyanSinhaMahapatra
Copy link
Member

Thanks++ @alok1304 , merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for False positive GPL3 license (not a bug)

2 participants