Skip to content

Conversation

@alok1304
Copy link
Collaborator

Fixes #3948
Replacing broken link for Sun Public License SPL 1.0 i.e change https://opensource.org/licenses/SPL-1.0 to https://opensource.org/license/sunpublic-php.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar [email protected]

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alok1304, update_spl_url sounds like variable name, not a commit message title. Could you amend your commit to have a nice title? Similarly like you have in the PR. See also https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

@AyanSinhaMahapatra
Copy link
Member

Thanks++ @alok1304 Merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 0e887a7 into aboutcode-org:develop Jun 25, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Sun Public License URL

2 participants