Skip to content

Improve license required phrase generation #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 22, 2025
Merged

Improve license required phrase generation #4237

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5fc22cf
Streamline rule validation
pombredanne Apr 13, 2025
57f6ed5
Tag existing rules as required phrases
pombredanne Apr 13, 2025
e9fe204
Update required phrase statuses for rules
pombredanne Apr 13, 2025
c532af7
Update required phrase statuses for rules
pombredanne Apr 13, 2025
e641691
Improve required phrase rules gen
pombredanne Apr 13, 2025
933ccfc
Generate more required phrase rules
pombredanne Apr 13, 2025
047e34b
Remove too verbose output
pombredanne Apr 13, 2025
bd7eac4
Update/generate more required phrase rules
pombredanne Apr 13, 2025
7a6d03e
Do not fail on license
pombredanne Apr 13, 2025
cd8389c
Correct tests after mass rule update
pombredanne Apr 14, 2025
a779a13
Improve license rules
pombredanne Apr 14, 2025
23317ed
Remove stopword from rule
pombredanne Apr 15, 2025
36bf8b8
Convert rule to required phrase
pombredanne Apr 15, 2025
78b8a65
Generate fewer required phrase rules
pombredanne Apr 15, 2025
8766095
Update rules for stopwords
pombredanne Apr 15, 2025
2ec6013
Merge branch '4190-license-licence' into improve-required
pombredanne Apr 21, 2025
1f789a2
Merge branch 'improve-required' into 4238-required-phrases-with-stopw…
pombredanne Apr 21, 2025
dc22bc2
Rename modified rule files
pombredanne Apr 22, 2025
c54321a
Merge latest 4190-license-licence branch
pombredanne Apr 22, 2025
494723a
Merge branch '4238-required-phrases-with-stopwords' into improve-requ…
pombredanne Apr 22, 2025
e0a8c42
Remove temp file committed by mistake.
pombredanne Apr 22, 2025
a5116ff
Update required phrases, rules and fix minor issues
AyanSinhaMahapatra Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
434 changes: 434 additions & 0 deletions plugin_license2.python
View file
Open in desktop
Copy link
Member Author

@pombredanne pombredanne Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... should not be committed. junk local file!

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/3dslicer-1.0_4.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
license_expression: 3dslicer-1.0
is_license_reference: yes
is_continuous: yes
is_required_phrase: yes
ignorable_urls:
- https://www.slicer.org/LICENSE
---

{{https://www.slicer.org/LICENSE}}
https://www.slicer.org/LICENSE
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/abstyles_2.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: abstyles
is_license_reference: yes
is_required_phrase: yes
---

Abstyles License
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/adapt-1.0_2.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: adapt-1.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
3 changes: 2 additions & 1 deletion src/licensedcode/data/rules/adobe-glyph_1.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: adobe-glyph
is_license_reference: yes
is_required_phrase: yes
---

Adobe Glyph
Adobe-Glyph
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/adobe-scl_4.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: adobe-scl
is_license_reference: yes
is_required_phrase: yes
---

Adobe Systems Incorporated Source Code License Agreement
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/adsl_2.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: adsl
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/afl-3.0.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: afl-3.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
ignorable_urls:
- http://opensource.org/licenses/afl-3.0.php
Expand Down
3 changes: 1 addition & 2 deletions src/licensedcode/data/rules/afmparse_1.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
---
license_expression: afmparse
is_license_reference: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
minimum_coverage: 100
notes: Rule based on an SPDX license identifier and name
---

Expand Down
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/afpl-9.0_4.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: afpl-9.0
is_license_reference: yes
is_required_phrase: yes
relevance: 99
---

Expand Down
2 changes: 0 additions & 2 deletions src/licensedcode/data/rules/agpl-1.0-plus_63.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
license_expression: agpl-1.0-plus
is_license_reference: yes
is_required_phrase: yes
is_continuous: yes
relevance: 100
minimum_coverage: 100
notes: Rule based on an SPDX license name and/or ID
---

Expand Down
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/agpl-1.0_4.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: agpl-1.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/agpl-2.0_1.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: agpl-2.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/agpl-2.0_4.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: agpl-2.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/agpl-3.0-plus_20.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: agpl-3.0-plus
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0-plus_264.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ license_expression: agpl-3.0-plus
is_license_reference: yes
is_required_phrase: yes
relevance: 100
minimum_coverage: 100
notes: Rule based on an SPDX license name and/or ID
---

Expand Down
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0-plus_271.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ license_expression: agpl-3.0-plus
is_license_tag: yes
is_required_phrase: yes
relevance: 100
minimum_coverage: 100
notes: Rule based on an SPDX license identifier and name
---

Expand Down
3 changes: 2 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0-plus_276.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
license_expression: agpl-3.0-plus
is_license_tag: yes
relevance: 100
is_required_phrase: yes
relevance: 99
---

- LicenseRef-AGPL
1 change: 1 addition & 0 deletions src/licensedcode/data/rules/agpl-3.0-plus_28.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
license_expression: agpl-3.0-plus
is_license_tag: yes
is_required_phrase: yes
relevance: 100
---

Expand Down
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/agpl-3.0-plus_285.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ ignorable_urls:
- https://spdx.org/licenses/AGPL-3.0-or-later
---

AGPL-3.0-or-later https://spdx.org/licenses/AGPL-3.0-or-later
AGPL-3.0-or-later https://spdx.org/licenses/AGPL-3.0-or-later
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0-plus_308.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0-plus
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDX-LicenseIdentifier: AGPL-3.0-or-later }}
SPDX-LicenseIdentifier: AGPL-3.0-or-later
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0-plus_309.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0-plus
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDXLicense-Identifier: AGPL-3.0-or-later }}
SPDXLicense-Identifier: AGPL-3.0-or-later
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0-plus_310.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0-plus
is_license_reference: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{AGPLv3 or later}}
AGPLv3 or later
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0-plus_required_phrase_1.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
license_expression: agpl-3.0-plus
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

GNU Affero General Public License as published by" "the Free Software Foundation, either version 3 of License, or" "(at your option) any later version
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/agpl-3.0_10.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ is_required_phrase: yes
relevance: 100
---

GNU Affero General Public License 3.0
GNU Affero General Public License 3.0
3 changes: 2 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0_176.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_required_phrase: yes
relevance: 100
---

__license__ = "{{AGPL-3.0-only}}"
__license__ = " AGPL-3.0-only "
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0_358.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ license_expression: agpl-3.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
minimum_coverage: 100
notes: Rule based on an SPDX license name and/or ID
---

Expand Down
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0_362.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ license_expression: agpl-3.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
minimum_coverage: 100
notes: Rule based on an SPDX license identifier and name
---

Expand Down
3 changes: 2 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0_370.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_required_phrase: yes
relevance: 100
---

- LicenseRef-{{AGPL-3.0}}
- LicenseRef-AGPL-3.0
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_410.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
notes: https://github.com/streetpea/chiaki-ng/blob/ba7402c4505ec4bd4ea9584dbcda5d6d5d8a2ee3/gui/io.github.streetpea.Chiaki4deck.appdata.xml
---

{{ <project_license>AGPL-3.0-only }}
<project_license>AGPL-3.0-only
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_411.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDX-LicenseIdentifier: AGPL-3.0-only }}
SPDX-LicenseIdentifier: AGPL-3.0-only
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_412.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDX-LicenseIdentifier: AGPL-3.0 }}
SPDX-LicenseIdentifier: AGPL-3.0
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_413.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDXLicenseIdentifier: AGPL-3.0-only }}
SPDXLicenseIdentifier: AGPL-3.0-only
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_414.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDXLicense-Identifier: AGPL-3.0-only }}
SPDXLicense-Identifier: AGPL-3.0-only
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_415.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_tag: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{ SPDXLicense-Identifier: AGPL-3.0 }}
SPDXLicense-Identifier: AGPL-3.0
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_416.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_reference: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{AGPLv3 only}}
AGPLv3 only
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/agpl-3.0_417.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: agpl-3.0
is_license_reference: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{AGPL v3 only}}
AGPL v3 only
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0_required_phrase_18.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
license_expression: agpl-3.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

GNU Affero General Public License as published by Free Software Foundation, either version 3 of License, or (at your option) any later version
1 change: 0 additions & 1 deletion src/licensedcode/data/rules/agpl-3.0_required_phrase_5.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
license_expression: agpl-3.0
is_license_reference: yes
is_required_phrase: yes
relevance: 100
---

GNU Affero General Public License as published by
Expand Down
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/amazon-sl_10.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
license_expression: amazon-sl
is_license_reference: yes
is_continuous: yes
is_required_phrase: yes
relevance: 100
---

{{Amazon Software License 1.0}}
Amazon Software License 1.0
Loading