Update test_detect.py

[pombredanne]

Fix lingering test failure

    def check_position(self, test_path, expected, with_span=True):
        """
        Check license detection in file or folder against expected result.
        Expected is a list of (license, lines span, qspan span) tuples.
        """
        test_location = self.get_test_loc(test_path)
        results = []
        # FULL INDEX!!
        idx = cache.get_index()
        matches = idx.match(test_location)
        for match in matches:
            for detected in match.rule.license_keys():
                results.append((detected, match.lines(), with_span and match.qspan or None))
>       assert results == expected
E       AssertionError: assert [('gpl-2.0-plus', (12, 25), Span(51, 160)),\n ('fsf-unlimited-no-warranty', (231, 238), Span(978, 1041)),\n ('warranty-disclaimer', (306, 307), Span(1351, 1373))] == [('gpl-2.0-plus', (12, 25), Span(48, 157)),\n ('fsf-unlimited-no-warranty', (231, 238), Span(965, 1028)),\n ('warranty-disclaimer', (306, 307), Span(1337, 1359))]
E         At index 0 diff: ('gpl-2.0-plus', (12, 25), Span(51, 160)) != ('gpl-2.0-plus', (12, 25), Span(48, 157))
E         Full diff:
E           [
E         -  ('gpl-2.0-plus', (12, 25), Span(48, 157)),
E         ?                                  ^^   ^^
E         +  ('gpl-2.0-plus', (12, 25), Span(51, 160)),
E         ?                                  ^^   ^^
E         -  ('fsf-unlimited-no-warranty', (231, 238), Span(965, 1028)),
E         ?                                                  ^^    ^^
E         +  ('fsf-unlimited-no-warranty', (231, 238), Span(978, 1041)),
E         ?                                                  ^^    ^^
E         -  ('warranty-disclaimer', (306, 307), Span(1337, 1359)),
E         ?                                               --- --
E         +  ('warranty-disclaimer', (306, 307), Span(1351, 1373)),
E         ?                                             +++++
E           ]

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁
• Updated documentation pages (if applicable)
• Updated CHANGELOG.rst (if applicable)

[pombredanne]

I am merging even though we still have this unrelated issue:

• Failure to build docs #4312