Skip to content

With requirement for fingerprint, we now need to build pyicu. #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jimjag
Copy link

@jimjag jimjag commented Jul 30, 2025

Update to-be-installed requirements as needed.

Fixes #4497

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • [ x Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Update to-be-installed requirements as needed.
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and the PR @jimjag
See my comments below on why we cannot update fingerprints just yet, as we want to continue to support python3.9

We can conditionally update fingerprints based on python versions like we do for click, attrs :

click >= 6.7, !=7.0, !=8.1.8;python_version<'3.10'

Could you update the PR accordingly so we can check if the tests pass allright?

@@ -22,7 +22,7 @@ extractcode==31.0.0
extractcode-7z==16.5.210531
extractcode-libarchive==3.5.1.210531
fasteners==0.19
fingerprints==1.2.3
fingerprints==1.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot upgrade fingerprints just yet, because they have removed support for python3.9, see https://github.com/opensanctions/fingerprints/blob/8eea92ff357e080c6c8bb0807352e7b5f83d9c14/pyproject.toml#L19C1-L19C28
This is not EOL yet: https://endoflife.date/python

Also why the tests are failing because we test and support python3.9.

Note also as mentioned in #4493 (comment), fingerprints is now unmaintained.
So we would want to consider switching to rigour in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on pyicu
2 participants