Fix: Remove a confusing rule that misidentified 'See LICENSE' text #4671
+9
−394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullPointer-cell
force-pushed
the
fix-unknown-license-rule
branch
from
39a23d7 to
cdab42e
Compare
added 2 commits
January 10, 2026 04:25
Signed-off-by: Jayan <[email protected]> Signed-off-by: Jayan <[email protected]>
Signed-off-by: Jayan <[email protected]>
NullPointer-cell
force-pushed
the
fix-unknown-license-rule
branch
from
59456d8 to
bc9144d
Compare
Author
|
Hi! I've completed the fix for issue #4481 by removing unknown_10.RULE which was causing false positive unknown-license-reference detections. Verification: ✅ Tested locally with node-cookie-signature v1.2.2 - now correctly shows only mit license ImportError: cannot import name 'py36' from 'commoncode.system' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where an unknown license rule was not being detected correctly.
It modifies the rule definitions to ensure proper detection coverage.
Related Issue
Fixes #[4481]
Checklist
pytest).Test Plan
I created a new test case in
tests/sourcedata/...and verified that the license is now correctly detected using:pytest -vvs tests/test_package_manifest.py