Improve Go/Rust/Elf/Mach0 binary symbol mapping #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #1707 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
tdruez
requested changes
Aug 12, 2025
Contributor
tdruez
left a comment
tdruez
left a comment
There was a problem hiding this comment.
Lack of unit test for the new functions.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Member
Author
|
@tdruez thanks! we have better test coverage now |
aayushkdev
pushed a commit
to aayushkdev/scancode.io
that referenced
this pull request
Aug 28, 2025
* Improve Go/Rust/Elf/Mach0 binary symbol mapping Reference: aboutcode-org#1707 Signed-off-by: Ayan Sinha Mahapatra <[email protected]> * Add unittests for new d2d modules Signed-off-by: Ayan Sinha Mahapatra <[email protected]> --------- Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
aayushkdev
added a commit
to aayushkdev/scancode.io
that referenced
this pull request
Aug 28, 2025
* Improve Go/Rust/Elf/Mach0 binary symbol mapping Reference: aboutcode-org#1707 Signed-off-by: Ayan Sinha Mahapatra <[email protected]> * Add unittests for new d2d modules Signed-off-by: Ayan Sinha Mahapatra <[email protected]> --------- Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1707
Reference: #1475