Skip to content

Conversation

@omsuneri
Copy link

@omsuneri omsuneri commented Oct 19, 2025

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
See some comments for your consideration

package_qs = get_queryset(project, "discoveredpackage")
package_qs = package_qs.prefetch_related("children_packages")

# Build a mapping of packages to their input sources when multiple inputs exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a function for that

bom_ref=str(project.uuid),
)

# Get input sources to potentially create components for them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a function

self.assertResultsEqual(expected_file, output_file.read_text())

def test_scanpipe_pipes_outputs_to_spdx_multiple_inputs(self):
"""Test SPDX generation with multiple input sources."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Test SPDX generation with multiple input sources."""


def test_scanpipe_pipes_outputs_to_cyclonedx_multiple_inputs(self):
"""Test CycloneDX generation with multiple input sources."""
project = make_project(name="MultiInputProject")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract a function for the shared setup between these SPDX and CDX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants