Added "META-INF" and "module-info.class" to ignore list #1943
+75
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Everything under META-INF/ is generally metadata or configuration files that can be ignored. - module-info.class is typically a generated file - it's the compiled version of a Java module descriptor that can be ignored as well. Signed-off-by: Chin Yeung Li <[email protected]>
- Added scan_ignored_to_files() - Updated tests Signed-off-by: Chin Yeung Li <[email protected]>
chinyeungli
changed the title
chinyeungli
requested review from
AyanSinhaMahapatra and
tdruez
and removed request for
AyanSinhaMahapatra
tdruez
requested changes
Nov 6, 2025
scanpipe/tests/pipes/test_d2d.py
Outdated
|
|
||
| self.assertEqual(1, expected) | ||
|
|
||
| def test_scan_ignored_to_files(self): |
Contributor
There was a problem hiding this comment.
The test name is not consistent with the existing.
Contributor
Author
There was a problem hiding this comment.
@tdruez what do you mean by "The test name is not consistent with the existing.". It is used to test the d2d.scan_ignored_to_files()
Contributor
There was a problem hiding this comment.
You need to follow the existing naming conventions. See all the tests function start with test_scanpipe_pipes_d2d_
Note that the other test you added in the PR respects the convention: test_scanpipe_pipes_d2d_java_ignore_pattern
Contributor
Author
There was a problem hiding this comment.
okay, thank. Updated.
Signed-off-by: Chin Yeung Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chin Yeung Li [email protected]