Merge branch dev with rel-10.1 #24596
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the routes component to use AsyncLocalizationPipe instead of LazyLocalizationPipe for route name localization. Adjusted template bindings to use the new pipe, improving consistency and potentially performance.
Appends the async pipe to the abpAsyncLocalization usage in routes.component.html to ensure localized route names are properly resolved from observables.
Replace LazyLocalizationPipe with AsyncLocalizationPipe
maliming
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges changes from the dev branch to rel-10.1, updating the routes component in the theme-basic package to use the new AsyncLocalizationPipe instead of the deprecated LazyLocalizationPipe. This change aligns with the framework's migration away from the deprecated pipe, which was renamed to better express its async nature.
Key Changes
- Replaced deprecated
LazyLocalizationPipewithAsyncLocalizationPipein imports - Updated template pipe usage from
abpLazyLocalizationtoabpAsyncLocalization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| npm/ng-packs/packages/theme-basic/src/lib/components/routes/routes.component.ts | Updated imports and standalone component imports array to use AsyncLocalizationPipe instead of deprecated LazyLocalizationPipe |
| npm/ng-packs/packages/theme-basic/src/lib/components/routes/routes.component.html | Updated template pipe references from abpLazyLocalization to abpAsyncLocalization in two locations (lines 15 and 42) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge dev with rel-10.1. Please review the changed files before merging to prevent any errors that may occur.