Skip to content

Fix aria dependency error #24694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erdemcaygor merged 2 commits into from
Jan 20, 2026
+2 −2
Merged

Fix aria dependency error #24694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3896b2e
Update @angular/aria peer dependency version
fahrigedik Jan 20, 2026
1c852c7
Set @angular/aria to exact version 21.0.0
fahrigedik Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npm/ng-packs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"@angular-eslint/eslint-plugin-template": "~21.0.0",
"@angular-eslint/template-parser": "~21.0.0",
"@angular/animations": "21.0.0",
"@angular/aria": "~21.0.0",
"@angular/aria": "21.0.0",
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version specifier for @angular/aria should use "~21.0.0" to be consistent with other Angular dependencies in devDependencies. Looking at lines 58, 60-72, all other @angular packages use the tilde range specifier (~21.0.0) except @angular/animations which uses an exact version. Using the tilde specifier allows patch version updates (21.0.x) which is more flexible and follows the project's convention.

Suggested change
"@angular/aria": "21.0.0",
"@angular/aria": "~21.0.0",

Copilot uses AI. Check for mistakes.
"@angular/build": "~21.0.0",
"@angular/cli": "~21.0.0",
"@angular/common": "~21.0.0",
Expand Down
2 changes: 1 addition & 1 deletion npm/ng-packs/packages/setting-management/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"tslib": "^2.0.0"
},
"peerDependencies": {
"@angular/aria": "^21.0.0"
"@angular/aria": "21.0.0"
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an exact version "21.0.0" in peerDependencies is too restrictive for a published library package. This means that consuming applications must have exactly version 21.0.0 installed, and won't work with patch versions like 21.0.1 or 21.0.2. For peerDependencies, a more appropriate specifier would be "^21.0.0" (allowing minor and patch updates) or ">=21.0.0" (allowing any version starting from 21.0.0), similar to how @abp/ng.components package.json uses ">=" for its peer dependencies. This provides consumers more flexibility while still ensuring compatibility.

Suggested change
"@angular/aria": "21.0.0"
"@angular/aria": ">=21.0.0"

Copilot uses AI. Check for mistakes.
},
"publishConfig": {
"access": "public"
Expand Down
Loading