Angular - Hybrid localization support by erdemcaygor · Pull Request #24731 · abpframework/abp

erdemcaygor · 2026-01-23T14:18:00Z

Resolves #24675

Copilot

Pull request overview

Adds hybrid UI localization support to ABP Angular by allowing client-side JSON localization resources to be loaded per language and merged with backend-provided resources (with UI taking precedence).

Changes:

Introduces UILocalizationService to load /assets/localization/{culture}.json (configurable) and register resources into LocalizationService.
Updates LocalizationService merge order so UI localizations override backend texts.
Exports and initializes the new service conditionally via core options.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
npm/ng-packs/packages/core/src/lib/services/ui-localization.service.ts	New service that loads UI localization JSON per culture and registers/records loaded resources.
npm/ng-packs/packages/core/src/lib/services/localization.service.ts	Adjusts merge order so UI resources override backend resources.
npm/ng-packs/packages/core/src/lib/services/index.ts	Exports the new UI localization service from the services barrel.
npm/ng-packs/packages/core/src/lib/providers/core-module-config.provider.ts	Conditionally initializes `UILocalizationService` during app init based on options.
npm/ng-packs/packages/core/src/lib/models/common.ts	Adds `uiLocalization` options to core ABP root configuration model.

Copilot · 2026-01-27T13:45:08Z

npm/ng-packs/packages/core/src/lib/services/localization.service.ts

              const remoteTexts = entry[1];
              let resource = local?.get(resourceName) || {};
-              resource = { ...resource, ...remoteTexts };
+              // UI > Backend priority: UI localization'lar backend'i override eder


The inline comment is partly in Turkish ("UI localization'lar backend'i override eder"), which is inconsistent with the rest of the codebase and makes the intent harder to understand for non-Turkish readers. Please rewrite it in English (and keep it consistent with the comment above about UI > Backend priority).

Suggested change

// UI > Backend priority: UI localization'lar backend'i override eder

// UI > Backend priority: UI localizations override backend localizations

Copilot · 2026-01-27T13:45:08Z

npm/ng-packs/packages/core/src/lib/services/ui-localization.service.ts

+export interface LocalizationResource {
+  [resourceName: string]: Record<string, string>;
+}


The exported interface name LocalizationResource is easy to confuse with ABP.LocalizationResource (already defined in models/common.ts) but represents a different shape (JSON file content keyed by resourceName). Consider renaming it to something more specific (e.g., UiLocalizationFile, UiLocalizationDictionary, etc.) to avoid ambiguity for consumers importing from the services barrel.

Copilot · 2026-01-27T13:45:09Z

npm/ng-packs/packages/core/src/lib/services/ui-localization.service.ts

+        distinctUntilChanged(),
+        switchMap(culture => this.loadLocalizationFile(culture)),
+        shareReplay(1),
+      )
+      .subscribe();


shareReplay(1) is applied to a stream that is immediately subscribed to and not exposed to other consumers, so it provides no benefit here and can be misleading. Consider removing it, or alternatively expose a shared observable if caching/reuse is intended.

Copilot · 2026-01-27T13:45:09Z

npm/ng-packs/packages/core/src/lib/providers/core-module-config.provider.ts

+      // Initialize UILocalizationService if UI-only mode is enabled
+      const options = inject(CORE_OPTIONS);
+      if (options?.uiLocalization?.enabled) {
+        inject(UILocalizationService);
+      }


The comment says "UI-only mode" but this feature appears to be hybrid UI+backend localization merging (based on uiLocalization options and the merge logic in LocalizationService). Please adjust the comment to accurately describe what is being enabled/initialized here.

Copilot · 2026-01-27T13:45:09Z

npm/ng-packs/packages/core/src/lib/services/ui-localization.service.ts

+  private loadLocalizationFile(culture: string) {
+    const config = this.options.uiLocalization;
+    if (!config?.enabled) return of(null);
+
+    const basePath = config.basePath || '/assets/localization';
+    const url = `${basePath}/${culture}.json`;
+
+    return this.http.get<LocalizationResource>(url).pipe(


This PR introduces new behavior (loading /assets/localization/{culture}.json and merging it with backend resources, including error handling when the file is missing), but there are no tests covering UILocalizationService. Since the package already has service-level tests under src/lib/tests (e.g. localization.service.spec.ts), please add tests that verify loading on language changes and UI > backend priority merging.

sumeyyeKurtulus · 2026-01-28T11:00:08Z

npm/ng-packs/packages/core/src/lib/services/ui-localization.service.ts

+      .pipe(
+        distinctUntilChanged(),
+        switchMap(culture => this.loadLocalizationFile(culture)),
+        shareReplay(1),


Hello @erdemcaygor thank you for developing a side feature to enhance the localization. I agree with the co-pilot command here.
The shareReplay(1) usage here is not needed since there is exactly one subscription for this observable.

fahrigedik · 2026-01-30T06:36:43Z

npm/ng-packs/apps/dev-app/src/app/localization-test/localization-test.component.ts

+  currentLanguage$ = this.sessionState.getLanguage$();
+
+  ngOnInit() {
+    // Yüklenen UI localization'ları göster


you can remove Turkish Comment Line

it is necessary change

fahrigedik · 2026-01-30T06:43:02Z

npm/ng-packs/packages/core/src/lib/services/ui-localization.service.ts

+import { SessionStateService } from './session-state.service';
+import { CORE_OPTIONS } from '../tokens/options.token';
+
+export interface UILocalizationResource {


The interface name UILocalizationResource might be confused with ABP.LocalizationResource (defined in abp\npm\ng-packs\packages\core\src\lib\models\common.ts), as they represent different structures:

ABP.LocalizationResource: { resourceName: string, texts: Record<string, string> }

UILocalizationResource: { [resourceName: string]: Record<string, string> } (dictionary format)

Consider renaming to something more descriptive like UiLocalizationDictionary or UiLocalizationFileContent to better reflect its purpose as the JSON file content format.

it is not necessary change

erdemcaygor added 2 commits January 22, 2026 18:52

hybrid localization

f62fa79

ui localization service added

7f9c976

erdemcaygor added this to the 10.2-preview milestone Jan 23, 2026

erdemcaygor added feature ui-angular labels Jan 23, 2026

erdemcaygor added 2 commits January 27, 2026 16:23

localization service updated

f585f7d

localization service updated

cdad015

erdemcaygor marked this pull request as ready for review January 27, 2026 13:40

erdemcaygor requested review from Copilot, fahrigedik and sumeyyeKurtulus January 27, 2026 13:40

Copilot started reviewing on behalf of erdemcaygor January 27, 2026 13:40 View session

refactoring

60322bd

Copilot AI reviewed Jan 27, 2026

View reviewed changes

example page added

5bc485c

sumeyyeKurtulus reviewed Jan 28, 2026

View reviewed changes

sumeyyeKurtulus and others added 3 commits January 28, 2026 14:04

update: comment

b7d61f2

refactoring

ef25844

tests added

cbe5e57

erdemcaygor requested a review from sumeyyeKurtulus January 29, 2026 12:57

fahrigedik approved these changes Jan 30, 2026

View reviewed changes

turkish comment removed

6a364d9

sumeyyeKurtulus approved these changes Feb 2, 2026

View reviewed changes

sumeyyeKurtulus merged commit ea3a62d into dev Feb 2, 2026
2 of 3 checks passed

sumeyyeKurtulus deleted the feat/#24675-hybrid-localization branch February 2, 2026 10:20

sumeyyeKurtulus mentioned this pull request Feb 2, 2026

Angular - Documentation for hybrid localization #24783

Closed

Copilot AI mentioned this pull request Feb 17, 2026

Angular - Documentation for hybrid localization #24819

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angular - Hybrid localization support#24731

Angular - Hybrid localization support#24731
sumeyyeKurtulus merged 10 commits intodevfrom
feat/#24675-hybrid-localization

erdemcaygor commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

sumeyyeKurtulus Jan 28, 2026 •

edited

Loading

Uh oh!

fahrigedik Jan 30, 2026

Uh oh!

fahrigedik Jan 30, 2026

Uh oh!

fahrigedik Jan 30, 2026

Uh oh!

fahrigedik Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// UI > Backend priority: UI localization'lar backend'i override eder
	// UI > Backend priority: UI localizations override backend localizations

Conversation

erdemcaygor commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

sumeyyeKurtulus Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fahrigedik Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

fahrigedik Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

fahrigedik Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

fahrigedik Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sumeyyeKurtulus Jan 28, 2026 •

edited

Loading