Added host parameter to TwitterOAuth::post() method #1073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Seeing that this PR has been open a while, it's unlikely it'll be merged. I was able to work around the issue anyways, so while it'd make things a bit easier it isn't really necessary anymore. The workaround just involves overriding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR mainly to attach meta data to images. There are a couple other endpoints like
media/subtitles/createormedia/subtitles/delete, tho, where this change could come in handy.There is already a similar PR #918, but that PR adds a new method for just the
media/metadata/createendpoint, whereas this PR allows to set the host on the existingpostmethod and can therefore be used for any of the other media endpoints as well. And since there is already a dedicated method for getting the upload status, I only made this change for thepostmethod.