Change bCountryCode from 0x21 (US) to 0x00 (irrelevant) #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
added a commit
to forderud/HIDPowerDevice
that referenced
this pull request
Jan 12, 2025
forderud
added a commit
to forderud/HIDPowerDevice
that referenced
this pull request
Jan 12, 2025
Update the D_HIDREPORT macro to set bCountryCode from 0x21 (US) to 0x00 (irrelevant) in the HID interface descriptor. Done since there's no reason for making battery and UPS devices specific to a single country. This also makes the sources more similar to to upstream Arduino sources on https://github.com/arduino/ArduinoCore-avr/blob/master/libraries/HID/src/HID.h Documentation: https://wiki.osdev.org/USB_Human_Interface_Devices#USB_Report_Protocol
forderud
force-pushed
the
bCountryCode-0
branch
from
137e491 to
5b5ded0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
D_HIDREPORTmacro to setbCountryCodefrom 0x21 (US) to 0x00 (irrelevant) in the HID interface descriptor. Done since there's no reason for making battery and UPS devices specific to a single country.This also makes the sources more similar to to upstream Arduino sources on https://github.com/arduino/ArduinoCore-avr/blob/master/libraries/HID/src/HID.h
Documentation: https://wiki.osdev.org/USB_Human_Interface_Devices#USB_Report_Protocol