fix(mailprotect): remove redundant db.close() causing "Cannot operate on a closed database #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug in mailprotect.py that causes the artifact parser to crash when processing iOS < 13 Mail data.
The crash was caused by a redundant
db.close()statement. Since the database is opened using a context manager (with open_sqlite_db_readonly...), the connection is automatically closed when the block exits. The explicit close call was creating a race condition or invalid state, leading tosqlite3.ProgrammingError: Cannot operate on a closed database.Changes
db.close()statement in mailprotect.py.Verification & Testing
I have created a reproduction script (test_mailprotect_fix.py) to verify the fix.
Test Output Summary:
Checklist
Related Issues
Closes #1386