fix: Fix invalid date handling in network usage data processing #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix year out of range error in netusage artifact
Fixed
ValueError: year 0 is out of rangethat occurred when processing timestamps with invalid or negative values in the netusage database.Before: Code attempted to convert invalid timestamps (resulting in year 0 or negative years) without validation
After: Added validation to check for invalid timestamps (starting with '0000') and wrapped timestamp conversions in try-except blocks to catch ValueError and OSError. Invalid timestamps are now set to empty strings
Error Messages Before Fix
ValueError: year 0 is out of range
Files changed:
scripts/artifacts/netusage.py