Open
Conversation
Owner
|
Hi @nmengin, thank you for the PR! I tried to avoid using any dependency management on the libkv side because I think it is better handled on the side of projects using the library (using dep/glide/godep/etc.). It is true that this is annoying because of occasional breakage of client libraries (for example recently with I'm not against including this change but I'm not sure this is entirely necessary either (considering the small scale of the project). Thoughts? |
Owner
|
Also it's broken on the CI somehow. |
Author
|
Ok @abronan. I just did it in the way to compile the master branch and submit you PR about ETCD management. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the new tool golang/dep for the libkv project.
This tool allows dependencies management.
Fix versions for dependencies as
constraintsoroverrideswhen necessary.