Make absl::from_chars_result compatible with C++20 and C++26 #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBkkt
changed the title
derekmauro
requested changes
Dec 30, 2024
absl/strings/charconv.h
Outdated
| absl::Nonnull<const char*> ptr; | ||
| std::errc ec; | ||
|
|
||
| bool operator==(const from_chars_result&) = default; |
There was a problem hiding this comment.
This change doesn't work prior to C++20. You will have to implement the operator method.
/abseil-cpp/absl/strings/charconv.h:51:8: error: defaulted 'bool absl::from_chars_result::operator==(const absl::from_chars_result&)' only available with '-std=c++20' or '-std=gnu++20'
51 | bool operator==(const from_chars_result&) = default;
Also, I know this is a simple change, but it still needs test coverage.
There was a problem hiding this comment.
@derekmauro Hi, I applied your suggestions to code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.cppreference.com/w/cpp/utility/from_chars_result