Skip to content

Hotfix: Add exclude to relations#84

Open
jeandelacruz wants to merge 1 commit intoabsent1706:masterfrom
jeandelacruz:hotfix/relations_exclude
Open

Hotfix: Add exclude to relations#84
jeandelacruz wants to merge 1 commit intoabsent1706:masterfrom
jeandelacruz:hotfix/relations_exclude

Conversation

@jeandelacruz
Copy link
Copy Markdown

@jeandelacruz jeandelacruz commented May 3, 2022

- I was able to observe that the option to exclude fields from serialization does not work, when they are relations

@michaelbukachi
Copy link
Copy Markdown
Collaborator

@jeandelacruz Where's the issue associated with this PR?

@jeandelacruz
Copy link
Copy Markdown
Author

@jeandelacruz Where's the issue associated with this PR?

It really was the need, as I was testing in a case where I have 2 related models and I wanted to exclude one of them, it couldn't be done, and that's where I saw the solution

@michaelbukachi
Copy link
Copy Markdown
Collaborator

@jeandelacruz Where's the issue associated with this PR?

It really was the need, as I was testing in a case where I have 2 related models and I wanted to exclude one of them, it couldn't be done, and that's where I saw the solution

I understand. However, we should always strive to create issues first before creating PRs in case further discussion is required.

@jeandelacruz
Copy link
Copy Markdown
Author

@jeandelacruz Where's the issue associated with this PR?

It really was the need, as I was testing in a case where I have 2 related models and I wanted to exclude one of them, it couldn't be done, and that's where I saw the solution

I understand. However, we should always strive to create issues first before creating PRs in case further discussion is required.

Thank you very much, I just added the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants