Skip to content

Replace regex with pattern as string to support OTP 28 #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwilson512 merged 1 commit into from
Apr 30, 2025
Merged

Replace regex with pattern as string to support OTP 28 #1360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions lib/absinthe/phase/schema/validation/names_must_be_valid.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ defmodule Absinthe.Phase.Schema.Validation.NamesMustBeValid do
use Absinthe.Phase
alias Absinthe.Blueprint

@valid_name_regex ~r/^[_A-Za-z][_0-9A-Za-z]*$/

def run(bp, _) do
bp = Blueprint.prewalk(bp, &validate_names/1)
Expand All @@ -30,7 +29,7 @@ defmodule Absinthe.Phase.Schema.Validation.NamesMustBeValid do
end

defp valid_name?(name) do
Regex.match?(@valid_name_regex, name)
Regex.match?(valid_name_regex(), name)
end

defp error(object, data) do
Expand All @@ -42,23 +41,20 @@ defmodule Absinthe.Phase.Schema.Validation.NamesMustBeValid do
}
end

@description """
Name does not match possible #{inspect(@valid_name_regex)} regex.

> Names in GraphQL are limited to this ASCII subset of possible characters to
> support interoperation with as many other systems as possible.

Reference: https://graphql.github.io/graphql-spec/June2018/#sec-Names

"""
defp valid_name_regex(), do: ~r/^[_A-Za-z][_0-9A-Za-z]*$/

def explanation(%{artifact: artifact, value: value}) do
artifact_name = String.capitalize(artifact)

"""
#{artifact_name} #{inspect(value)} has invalid characters.

#{@description}
Name does not match possible #{inspect(valid_name_regex())} regex.

> Names in GraphQL are limited to this ASCII subset of possible characters to
> support interoperation with as many other systems as possible.

Reference: https://graphql.github.io/graphql-spec/June2018/#sec-Names
"""
end
end
Loading