fix: leaked async tasks in Incremental.Supervisor #1412
+26
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start_deferred_task/1 and start_stream_task/1 used async_nolink without awaiting, leaking a result message and DOWN message into the caller's mailbox per task. Replace with start_child, which is true fire-and-forget.
QuinnWilton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this issue was found while running a static analysis tool I'm working on. It seems like a legitimate finding, but it wasn't an issue I ran into while using
Absinthe.start_deferred_task/1andstart_stream_task/1usedasync_nolinkwithout awaiting, leaking a result message and:DOWNmessage into the caller's mailbox per task. Replace withstart_child, which is true fire-and-forget.