Skip to content

Use runtime config for assets #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szajbus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use runtime config for assets #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/absinthe/plug/graphiql.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ defmodule Absinthe.Plug.GraphiQL do
interface: :playground | :advanced | :simple,
default_headers: {module, atom},
default_url: binary,
assets: Keyword.t(),
socket: module,
socket_url: binary
]
Expand Down
12 changes: 7 additions & 5 deletions lib/absinthe/plug/graphiql/assets.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ defmodule Absinthe.Plug.GraphiQL.Assets do
@moduledoc """
"""

@config Application.compile_env(:absinthe_plug, Absinthe.Plug.GraphiQL)
@default_config [
source: :smart,
local_url_path: "/absinthe_graphiql",
Expand Down Expand Up @@ -72,10 +71,13 @@ defmodule Absinthe.Plug.GraphiQL.Assets do
]}
]

if @config do
def assets_config, do: Keyword.merge(@default_config, Keyword.get(config, :assets, []))
else
def assets_config, do: @default_config
def assets_config do
runtime_config =
:absinthe_plug
|> Application.get_env(Absinthe.Plug.GraphiQL, [])
|> Keyword.get(:assets, [])

Keyword.merge(@default_config, runtime_config)
end

def get_assets do
Expand Down