feat: Add Server-Sent Events transport for incremental delivery#306
feat: Add Server-Sent Events transport for incremental delivery#306jwaldrip wants to merge 10 commits intoabsinthe-graphql:mainfrom
Conversation
Implements SSE transport for @defer and @stream directives: - Server-Sent Events (SSE) adapter for HTTP streaming - Multipart response format support - Proper chunked transfer encoding DEPENDS ON: absinthe package defer-stream-incremental branch must be merged first 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
BREAKING: Refactored single-file SSE implementation into modular structure: - SSE.EventFormatter: Event formatting utilities - SSE.ConnectionManager: Connection lifecycle management - SSE.QueryProcessor: GraphQL query processing - SSE.Router: Phoenix router helpers and plugs docs: Add comprehensive HTTP/SSE incremental delivery documentation - Server-Sent Events implementation guide - Client-side integration examples (vanilla JS, React) - Performance optimization and monitoring - Security considerations and troubleshooting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…y testing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…very Point to gigsmart/absinthe branch gigmart/defer-stream-incremental for testing the @defer and @stream directive implementation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update installation dependencies in README_INCREMENTAL.md to point to the remote git repositories instead of hex packages for testing incremental delivery features. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Move incremental delivery content from temporary README_INCREMENTAL.md into the main README.md file. Remove temporary file and properly document the HTTP/SSE incremental delivery features. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Checking in on the SSE transport for incremental delivery. This is a companion to absinthe#1377. Any thoughts or concerns? |
bryanjos
left a comment
bryanjos
left a comment
There was a problem hiding this comment.
This looks good so far. If possible, it would be nice to have some tests for it. And like you mentioned it will have to wait until the absinthe changes merge in. Then you can update the dependency references
|
FYI There is support for SSE for subscriptions here already: https://github.com/absinthe-graphql/absinthe_plug/blob/main/lib/absinthe/plug.ex#L366-L401 Might be worth reviewing that for overlap, maybe SSE support could be unified |
- Refactor existing subscription SSE to use shared ConnectionManager for header setup, unifying SSE support between subscriptions and incremental delivery (addresses overlap noted by @binaryseed) - Standardize keep-alive comment format (: keep-alive) across both paths - Add comprehensive tests for EventFormatter (event formatting, error response wrapping) and ConnectionManager (accept detection, header setup, keep-alive scheduling) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@binaryseed Good call — there was definitely overlap between the existing subscription SSE in
The two remain separate at the event loop level since they handle fundamentally different message patterns (subscription broadcasts vs incremental delivery payloads), but the connection infrastructure is now shared. @bryanjos Added tests for |
3 participants
Summary
This PR adds Server-Sent Events (SSE) transport support to absinthe_plug for incremental delivery with @defer and @stream directives.
This PR depends on gigsmart/absinthe#gigmart/defer-stream-incremental
The main absinthe package must be merged first before this PR can be merged.
Features
Implementation
Absinthe.Plug.Incremental.SSE- SSE transport adapterTesting
Breaking Changes
None - incremental delivery is opt-in and backward compatible.