Support Elixir 1.19/OTP 28 and bump actions#307
Open
kianmeng wants to merge 1 commit intoabsinthe-graphql:mainfrom
Open
Support Elixir 1.19/OTP 28 and bump actions#307kianmeng wants to merge 1 commit intoabsinthe-graphql:mainfrom
kianmeng wants to merge 1 commit intoabsinthe-graphql:mainfrom
Conversation
kianmeng
commented
Sep 10, 2025
Comment on lines
+6
to
+10
| setup_all do | ||
| TestPubSub.start_link() | ||
| Absinthe.Subscription.start_link(TestPubSub) | ||
| :ok | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Sporadic error in CI:
1) test Subscriptions over HTTP with Server Sent Events chunked response (standard) (Absinthe.PlugTest)
Error: test/lib/absinthe/plug_test.exs:485
** (EXIT from #PID<0.332.0>) shutdown: failed to start child: Absinthe.Plug.TestPubSub.Registry
** (EXIT) already started: #PID<0.315.0>
.........................
Finished in 0.7 seconds (0.7s async, 0.00s sync)
86 tests, 1 failure
Randomized with seed 116773
Error: Process completed with exit code 2.
kianmeng
commented
Sep 10, 2025
Comment on lines
+5
to
+6
| import Plug.Test | ||
| import Plug.Conn |
Contributor
Author
There was a problem hiding this comment.
warning: use Plug.Test is deprecated. Please use `import Plug.Test` and `import Plug.Conn` directly instead.
│
2 │ use Absinthe.Plug.TestCase
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/lib/absinthe/plug_test.exs:2: Absinthe.PlugTest (module)
warning: use Plug.Test is deprecated. Please use `import Plug.Test` and `import Plug.Conn` directly instead.
│
3 │ use Absinthe.Plug.TestCase
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/lib/absinthe/plug/transport_batching_test.exs:3: Absinthe.Plug.TransportBatchingTest (module)
warning: use Plug.Test is deprecated. Please use `import Plug.Test` and `import Plug.Conn` directly instead.
│
3 │ use Plug.Test
│ ~~~~~~~~~~~~~
│
└─ test/lib/absinthe/graphiql_test.exs:3: Absinthe.Plug.GraphiQLTest (module)
warning: use Plug.Test is deprecated. Please use `import Plug.Test` and `import Plug.Conn` directly instead.
│
2 │ use Absinthe.Plug.TestCase
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/lib/absinthe/plug/document_provider_test.exs:2: Absinthe.Plug.DocumentProviderTest (module)
warning: use Plug.Test is deprecated. Please use `import Plug.Test` and `import Plug.Conn` directly instead.
│
2 │ use Absinthe.Plug.TestCase
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/lib/absinthe/plug/document_provider/compiled_test.exs:2: Absinthe.Plug.DocumentProvider.CompiledTest (module)
kianmeng
commented
Sep 10, 2025
| app: :absinthe_plug, | ||
| version: @version, | ||
| elixir: "~> 1.13", | ||
| elixir: "~> 1.15", |
Contributor
Author
There was a problem hiding this comment.
Tally with both absinthe and phoenix minimu Elixir version requirement.
This PR updates the project to support newer Elixir (1.18) and OTP (28) versions, along with modernizing the codebase and updating CI configurations to match.
kianmeng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the project to support newer Elixir (1.18/1.19) and OTP (28) versions, along with modernizing the codebase and updating CI configurations to match.