SMQ-226 - Add built-in admin role deletions restrictions to docs#223
Merged
dborovcanin merged 5 commits intoabsmach:mainfrom Jun 4, 2025
Merged
SMQ-226 - Add built-in admin role deletions restrictions to docs#223dborovcanin merged 5 commits intoabsmach:mainfrom
dborovcanin merged 5 commits intoabsmach:mainfrom
Conversation
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
changed the title
Musilah
reviewed
May 13, 2025
Contributor
Musilah
left a comment
Musilah
left a comment
There was a problem hiding this comment.
There are some examples that are empty. Could you kindly add the response jsons?
Musilah
reviewed
May 13, 2025
docs/roles.md
Outdated
| --- | ||
|
|
||
| ### **4. Delete a Role** | ||
| #### 4. **Update a Role** |
Contributor
There was a problem hiding this comment.
Suggested change
| #### 4. **Update a Role** | |
| ### 4. **Update a Role** |
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
dborovcanin
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates the role management documentation to describe safeguards that prevent administrative lockout or orphaned domains.
Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
Yes
Notes