Skip to content

Commit 2223edb

Browse files
committed
Address comments
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
1 parent a48cbc5 commit 2223edb

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

domains/service.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,8 @@ func (svc *service) RoleRemoveMembers(ctx context.Context, session authn.Session
367367
return errors.Wrap(svcerr.ErrViewEntity, err)
368368
}
369369
if membersPage.Total <= uint64(len(members)) {
370-
return errors.Wrap(svcerr.ErrRemoveEntity, err)
370+
errAtLeastOneMemberRetain := errors.New("at least one member should be in built-in role")
371+
return errors.Wrap(svcerr.ErrRemoveEntity, errAtLeastOneMemberRetain)
371372
}
372373
}
373374

@@ -392,7 +393,8 @@ func (svc *service) RoleRemoveAllMembers(ctx context.Context, session authn.Sess
392393
return errors.Wrap(svcerr.ErrViewEntity, err)
393394
}
394395
if membersPage.Total > 0 {
395-
return errors.Wrap(svcerr.ErrRemoveEntity, err)
396+
errAtLeastOneMemberRetain := errors.New("at least one member should be in built-in role")
397+
return errors.Wrap(svcerr.ErrRemoveEntity, errAtLeastOneMemberRetain)
396398
}
397399
}
398400

0 commit comments

Comments
 (0)