Skip to content

moved _allMarketplaces below the marketplaces because of static field initilization order #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
babuscam wants to merge 1 commit into from
Closed

moved _allMarketplaces below the marketplaces because of static field initilization order #906

babuscam wants to merge 1 commit into from

Conversation

@babuscam
Copy link
Contributor

@babuscam babuscam commented Dec 23, 2025

  • moved _allMarketplaces below the marketplaces, because static fields are initialized in the order they appear in the source code and allMarketplaces had null values

@babuscam
moved _allMarketplaces below the marketplaces, because static fields …
fdd4da3 
…are initialized in the order they appear in the source code and allMarketplaces had null values
@pandapknaepel
Copy link

pandapknaepel commented Jan 15, 2026

I just ran into this exact bug with a NullReferenceException in GetMarketPlaceByID. As the contributor correctly identified, the static initialization order causes _allMarketplaces to be populated with null values.

@abuzuhri, this is a critical fix for anyone using the marketplace utility methods. Please consider merging this PR to restore stability.

@pandapknaepel pandapknaepel mentioned this pull request Jan 15, 2026
Closed
@ProNotion
Copy link
Collaborator

ProNotion commented Jan 15, 2026

A small typo still in the file marketpalce should be marketplace 👍

@TManITtech
Copy link
Contributor

TManITtech commented Jan 15, 2026

I also get this critical error:

System.NullReferenceException: Object reference not set to an instance of an object.
   at FikaAmazonAPI.Utils.MarketPlace.<>c__DisplayClass19_0.<GetMarketPlaceByID>b__0(MarketPlace a)
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
   at FikaAmazonAPI.Utils.MarketPlace.GetMarketPlaceByID(String id)

@abuzuhri please expedite this fix asap.

TManITtech
TManITtech approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@TManITtech TManITtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix and it works.

@abuzuhri
Copy link
Owner

abuzuhri commented Jan 17, 2026

Its fixed now before i see this PR

@abuzuhri abuzuhri closed this Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TManITtech TManITtech TManITtech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@babuscam @pandapknaepel @ProNotion @TManITtech @abuzuhri