Skip to content

moved _allMarketplaces below the marketplaces because of static field initilization order #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
babuscam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

moved _allMarketplaces below the marketplaces because of static field initilization order #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions Source/FikaAmazonAPI/Utils/MarketPlace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,33 +25,6 @@ private MarketPlace(string id, Region region, Country country, BaseCurrencyCode

[JsonConstructorAttribute]
public MarketPlace() { }

private static readonly List<MarketPlace> _allMarketplaces = new List<MarketPlace>()
{
// NorthAmerica
US, Canada, Mexico, Brazil,
// Europe
Spain, UnitedKingdom, France, Belgium,
Netherlands, Germany, Italy, Sweden,
Egypt, Poland, Turkey, UnitedArabEmirates,
India, SaudiArabia, SouthAfrica, Ireland,
// FarEast
Singapore, Australia, Japan
};

public static MarketPlace GetMarketPlaceByID(string id)
{
var marketpalce = _allMarketplaces.FirstOrDefault(a => a.ID == id);
if (marketpalce == null)
throw new AmazonInvalidInputException($"InvalidInput, MarketPlace or MarketPlaceID cannot be null for both!");

return marketpalce;
}

public static MarketPlace GetMarketplaceByCountryCode(string countryCode)
{
return _allMarketplaces.FirstOrDefault(a => a.Country.Code == countryCode);
}

//https://developer-docs.amazon.com/sp-api/docs/marketplace-ids

Expand Down Expand Up @@ -84,5 +57,32 @@ public static MarketPlace GetMarketplaceByCountryCode(string countryCode)
public static readonly MarketPlace Singapore = new MarketPlace("A19VAU5U5O7RUS", Region.FarEast, Country.SG, BaseCurrencyCode.SGD);
public static readonly MarketPlace Australia = new MarketPlace("A39IBJ37TRP1C6", Region.FarEast, Country.AU, BaseCurrencyCode.AUD);
public static readonly MarketPlace Japan = new MarketPlace("A1VC38T7YXB528", Region.FarEast, Country.JP, BaseCurrencyCode.JPY);

private static readonly List<MarketPlace> _allMarketplaces = new List<MarketPlace>()
{
// NorthAmerica
US, Canada, Mexico, Brazil,
// Europe
Spain, UnitedKingdom, France, Belgium,
Netherlands, Germany, Italy, Sweden,
Egypt, Poland, Turkey, UnitedArabEmirates,
India, SaudiArabia, SouthAfrica, Ireland,
// FarEast
Singapore, Australia, Japan
};

public static MarketPlace GetMarketPlaceByID(string id)
{
var marketpalce = _allMarketplaces.FirstOrDefault(a => a.ID == id);
if (marketpalce == null)
throw new AmazonInvalidInputException($"InvalidInput, MarketPlace or MarketPlaceID cannot be null for both!");

return marketpalce;
}

public static MarketPlace GetMarketplaceByCountryCode(string countryCode)
{
return _allMarketplaces.FirstOrDefault(a => a.Country.Code == countryCode);
}
}
}
Loading