Fix route param parsing when the param begins with just one letter (rebased original PR #686 by @ahoseinian) #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2025
🦋 Changeset detectedLatest commit: 6d9e920 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nicky1038
force-pushed
the
bugfix/fix-route-path-params-parsing
branch
2 times, most recently
from
11ba2f3 to
1fd32de
Compare
Contributor
Author
|
Things done in this PR that were not in the original one:
|
For example if the param was i_key the current regex would not find it as a variable. it was only working for the params with more than one letter before either `.` `-` or `_`. the fix should allow to find params with only one letter at begninng.
accourding to this suggestion acacode#686 (comment)
smorimoto
force-pushed
the
bugfix/fix-route-path-params-parsing
branch
from
1fd32de to
0d4a3ce
Compare
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
approved these changes
Mar 22, 2025
Collaborator
|
@nicky1038 Let me know what you think about the last commit. The last commit feels fine to me. |
smorimoto
approved these changes
Mar 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the way how query params are parsed when they consist of one letter or the first letter is followed by underscore.
Original #686 by @ahoseinian was needed to be rebased.
So I did it myself because of no activity there.